From: Junio C Hamano Date: Mon, 19 Feb 2007 01:50:50 GMT Subject: Re: [PATCH] Add git-bundle: move objects and references by archive. Message-ID: <7v7iuedif9.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Johannes Schindelin writes: > Sorry to be such a PITA, but I really, really think that it is wrong to > make a tar dependency here. You said your cygwin has problems with binary > files. Could you please try this: > > $ echo -ne '\x1a\x1b\x15\x10\0abc' | cat | wc It might be just me, but "echo -e" makes me feel much more uneasy than explicitly saying "Sorry, we require GNU tar in this little corner of the system". >> + bfile=$1 > > This can contain spaces (you are working on Windows, right? Windows users > _love_ spaces in their filenames). Which is fine. Try var1=$var2 with something with SP or TAB in var2 and later try running $ echo "<$var1>" to see what happens. >> + gitrevargs=$(git-rev-parse --symbolic --revs-only $args) || exit 1 > > Here, you rely again on the refs not containing spaces. Which probably is fine, as refs cannot contain spaces ;-). >> + # git-rev-list cannot determine edge objects if a date restriction is >> + # given... we do things a slow way if max-age or min-age are given > > Might make sense to teach max-age about boundary commits instead... You are talking about a rather extensive change, but could be done. But that is a separate issue, I think.