From: Junio C Hamano <junkio@cox.net>
Date: Sun, 15 Apr 2007 22:54:47 GMT
Subject: Re: [PATCH] entry.c: Use strerror() to print error info when possible
Message-ID: <7v7isd2qq0.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070415185619.3fa90f3a@gnut>

"Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br>
writes:

> Signed-off-by: Luiz Fernando N. Capitulino <lcapitulino@mandriva.com.br>
> ---
>  entry.c |   11 ++++++-----
>  1 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/entry.c b/entry.c
> index d72f811..c36c09d 100644
> --- a/entry.c
> +++ b/entry.c
> @@ -19,7 +19,8 @@ static void create_directories(const char *path, struct checkout *state)
>  				if (!stat(buf, &st) && S_ISDIR(st.st_mode))
>  					continue; /* ok */
>  			}
> -			die("cannot create directory at %s", buf);
> +			die("cannot create directory at %s (%s)", buf,
> +			    strerror(errno));
>  		}
>  	}
>  	free(buf);

This hunk is wrong; stat() you see in the context could have
been what failed the last before this die().

I do not think other places you patched do not share the issue.