From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 09 Dec 2007 18:27:01 GMT
Subject: Re: [PATCH 3/4] Move the file read logic to read_patch_file() in builtin-apply.c
Message-ID: <7v7ijnpvuy.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1197219900-19334-3-git-send-email-mh@glandium.org>

Mike Hommey <mh@glandium.org> writes:

> This will allow to extend the read logic further. We also return a better
> error message than usage() when the given filename can't be opened, and
> avoid whitespace options not being set when reading from stdin with the
> "-" argument as a side effect.

I think this is a good clean-up, but I suspect that apply_patch() should
be further refactored to take strbuf, instead of <fd, filename>
(original) or <filename> (yours).