From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 13 Feb 2008 19:50:41 GMT
Subject: Re: [PATCH] hash-object: don't rely on order of --stdin, -w arguments
Message-ID: <7v7ih8pre6.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080213190338.7393.qmail@d70c5cbe18d4bd.315fe32.mid.smarden.org>

Gerrit Pape <pape@smarden.org> writes:

> Fix 'git hash-object --stdin -w' to actually write the object, just as
> 'git hash-object -w --stdin' does.

Can we have additions to the test scripts to illustrate:

 - what used to happen if you had "--stdin -w" on the command
   line (presumably you did not get the object written, which is
   a buggy behaviour and the patch should fix it);

 - what used to happen if you had "-w --stdin --stdin" on the
   command line (I imagine you used to be able to feed two
   separate streams when you are on a terminal by typing ^Ds in
   between?);

 - any other combination that may deserve testing.

in order to (1) show existing bugs the patch is trying to
address, (2) demonstrate that the patch fixes them without
regressing, and (3) protect the fix from being broken by future
changes, pretty please?