From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 22 Feb 2008 20:54:24 GMT
Subject: Re: [PATCH] hash: fix lookup_hash semantics
Message-ID: <7v7igw90fz.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080222194726.GA24532@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> We were returning the _address of_ the stored item (or NULL)
> instead of the item itself. While this sort of indirection
> is useful for insertion (since you can lookup and then
> modify), it is unnecessary for read-only lookup.

Very nicely spotted.  Thanks.