From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 05 Aug 2008 06:12:01 GMT
Subject: Re: [PATCH] Git.pm: localise $? in command_close_bidi_pipe()
Message-ID: <7v7iawxa6m.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080804113827.GA1239@toroid.org>

Abhijit Menon-Sen <ams@toroid.org> writes:

> With my patch, however, Git::DESTROY calls the two _close functions
> during global destruction, which in turn call command_close_bidi_pipe,
> which calls waitpid with sensible arguments this time, which alters $?,
> thus altering the exit status of the dcommit itself to 0. Oops.

Thanks.