From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 23 Sep 2008 01:46:11 GMT
Subject: Re: [PATCH] diff funcname_pattern: Allow HTML header tags without attributes
Message-ID: <7v7i93ws64.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <200809230249.23298.johan@herland.net>

Johan Herland <johan@herland.net> writes:

> After looking over this once more, I think the HTML regexp should be
> changed as follows. This fixes a buglet that was part of my original
> HTML pattern, and although this patch textually depends on Brandon's
> work, it is conceptually independent of his refactorization.
> ...
> -	{ "html", "^[ \t]*(<[Hh][1-6][ \t].*>.*)$", REG_EXTENDED },
> +	{ "html", "^[ \t]*(<[Hh][1-6]([ \t].*)?>.*)$", REG_EXTENDED },

I do not think these two particularly would make much difference.  Why
isn't it simply...

	"<[Hh][1-6].*"

without even any capture or anchor?

It would falsely hit oddball cases like <h1foo> which is not <h1>, but
anybody who uses such a nonstandard thing deserves it, imnvho ;-).