From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 07 Jun 2009 23:28:33 GMT
Subject: Re: [PATCH 2/6] add a test for git-send-email for threaded mails without chain-reply-to
Message-ID: <7v7hznaaji.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1244410857-920-3-git-send-email-markus.heidelberg@web.de>

Markus Heidelberg <markus.heidelberg@web.de> writes:

> +test_expect_failure 'threading but no chain-reply-to' '
> +	git send-email \
> +		--dry-run \
> +		--from="Example <nobody@example.com>" \
> +		--to=nobody@example.com \
> +		--thread \
> +		--nochain-reply-to \
> +		$patches $patches |
> +	grep "In-Reply-To: "
> +'

Thanks, but this is not a very good style, as it won't catch if "git
send-email" dumps core or otherwise fails, exiting with a non-zero status.

Same comments applies to [PATCH 4/6] as well.