From: Junio C Hamano Date: Thu, 10 Sep 2009 18:56:39 GMT Subject: Re: [PATCH v3 3/3] INSTALL: Describe dependency knobs from Makefile Message-ID: <7v7hw6aas8.fsf@alter.siamese.dyndns.org> In-Reply-To: <1252591928-2278-1-git-send-email-brian@gernhardtsoftware.com> Brian Gernhardt writes: > We said that some of our dependencies were optional, but didn't say > how to turn them off. Add information for that and mention where to > save the options close to the top of the file. > > Also, standardize on both using quotes for the names of the dependencies > and tabs for indentation of the list. > > Signed-off-by: Brian Gernhardt > --- > > Junio C Hamano wrote: > > I did not like calling "make variables" "options", and also it was unclear > > what good these "options" are for. How about... > > Sounds good. Would have sent this out yesterday, but I ran out of tuits. > > INSTALL | 38 ++++++++++++++++++++++++-------------- > 1 files changed, 24 insertions(+), 14 deletions(-) > > diff --git a/INSTALL b/INSTALL > index 7ab2580..69c97b2 100644 > --- a/INSTALL > +++ b/INSTALL > @@ -13,6 +13,10 @@ that uses $prefix, the built results have some paths encoded, > which are derived from $prefix, so "make all; make prefix=/usr > install" would not work. > > +There are many options that can be configured in the makefile using either > +command line defines or a config.mak file. These options are documented at > +the beginning of the Makefile. Sorry, but the description still speaks of options and does not say what good they are. Sent a wrong patch?