From: Junio C Hamano Date: Tue, 17 Nov 2009 06:37:09 GMT Subject: Re: [PATCH] Doc: mention the crlf attribute in config autocrlf section Message-ID: <7v7htpirmy.fsf@alter.siamese.dyndns.org> In-Reply-To: <20091117035945.GA1728@comcast.net> Matthew Ogilvie writes: > On Mon, Nov 16, 2009 at 07:50:48PM +0900, Nanako Shiraishi wrote: >> Quoting Matthew Ogilvie >> >> > The reverse reference has long existed, and the autocrlf description >> > was actually obsolete and wrong (saying only file content is used), >> > not just incomplete. >> >> What do you mean by "reverse reference"? > > I'm refering to the fact that the "crlf" section of > Documentation/gitattributes.txt mentions core.autocrlf, > which is in the opposite (reverse) direction as this new reference > I'm adding. > ... > Do I need to resubmit the patch, in order to rephrase the commit > message? Thanks; I heard you, as your response was Cc'ed to me as well ;-) How about this? I didn't touch the patch text (other than dropping trailing whitespaces). commit ff68668695486b72b5f06146eddf85b70841088a Author: Matthew Ogilvie Date: Sat Nov 14 11:35:00 2009 -0700 core.autocrlf documentation: mention the crlf attribute The description of the configuration variable is obsolete and wrong (saying only file content is used), not just incomplete. It has used the attribute mechanism for a long time. The documentation of gitattributes mentions the core.autocrlf configuration variable in its description of crlf attribute. Refer to the gitattributes documentation from here as well. Signed-off-by: Matthew Ogilvie Signed-off-by: Junio C Hamano