From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 29 Mar 2011 01:01:52 GMT
Subject: Re: [PATCH] Remove "bashism" from contrib/thunderbird-patch-inline/appp.sh
Message-ID: <7v7hbiviwv.fsf@alter.siamese.dyndns.org>
In-Reply-To: <AANLkTin-USDnTxeKT_KOZW5kgC0vFXYbMNP9ct6fzbUC@mail.gmail.com>

Maxin john <maxin@maxinbjohn.info> writes:

> Remove "bashism" and minor corrections for
> contrib/thunderbird-patch-inline/appp.sh

The script seems to only use standard POSIX shell features and nothing
particularly bash specific nor outside POSIX in general that we exclude
from our coding standards (e.g. "local", use of "function" noiseword,
substring expansion ${parmeter:offset:length}).

It is better to explain the patch as

  Subject: contrib/thunderbird-patch-inline: do not require /bin/bash to run