From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 27 Sep 2011 17:17:20 GMT
Subject: Re: [PATCH] gitweb: Fix links to lines in blobs when javascript-actions are enabled
Message-ID: <7v7h4tykf3.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1317117060-3955-1-git-send-email-peter@stuge.se>

Peter Stuge <peter@stuge.se> writes:

> Some javascript code will run in the browser onLoad and signals back to
> gitweb that the browser can actually do javascript.
>
> The code adds [?;]js=1 into the URL of all links on the page. The code
> always added [?;]js=1 to the end of links, which is wrong when links
> contain a URI fragment, such as links directly to a line in a blob:
> ..?p=repo.git;a=blob;f=file#l123
>
> In this case, [?;]js=1 must be added before the hashmark.
>
> Signed-off-by: Peter Stuge <peter@stuge.se>

Nicely done. You forgot to mention another bug you fixed (see Jakub's
sample in the thread), so I'll amend in a few sentences to describe it as
well.

Thanks.