From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 16 Dec 2011 17:01:57 GMT
Subject: Re: [PATCH] attr: map builtin userdiff drivers to well-known extensions
Message-ID: <7v7h1wjvqy.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4EEB4F13.2010402@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

> Am 12/16/2011 12:00, schrieb Jeff King:
>>  static const char *builtin_attr[] = {
> ...
>> +	"*.c diff=cpp",
>> +	"*.cc diff=cpp",
>> +	"*.cxx diff=cpp",
>> +	"*.cpp diff=cpp",
>> +	"*.h diff=cpp",
>> +	"*.hpp diff=cpp",
>
> Please don't do this. It would be a serious regression for C++ coders, and
> some C coders as well. The built-in hunk header patterns are severly
> broken and don't work well with C++ code.

I do not often do C++, but I tend to agree wrt C.