From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 23 Feb 2012 19:53:24 GMT
Subject: Re: [PATCH] pretty: add '*' modifier to add LF after non-empty
Message-ID: <7v7gzd498r.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1330002637-9347-1-git-send-email-pionchon.luc@gmail.com>

Luc Pionchon <pionchon.luc@gmail.com> writes:

> Add the '*' modifier, similar to the '+' modifier,
> to add a line-feed after a non-empty placeholder.

Hrm, I thought I designed the plus and minus fairly carefully so that
nobody needs to add this later.

Wouldn't it be sufficient to write

        Foo%n%-d

that says "We usually have LF after Foo, and write %d after that, but we
might not have anything interesting in %d at all, in which case we don't
add that %n"?

> +test_expect_success 'add LF after non-empty (1) (empty)' '
> +	git show -s --pretty=format:"%*d%s%nfoo%n" HEAD^^ >actual &&

Shouldn't this be equivalent to "%n%-d%s%nfoo%n", which in turn is covered
by one of the previous tests (del LF before empty)?