From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 01 Mar 2012 18:33:37 GMT
Subject: Re: [PATCH v2 2/3] http: try http_proxy env var when http.proxy config option is not set
Message-ID: <7v7gz4npby.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4F4FB5BF.8000904@vilain.net>

Sam Vilain <sam@vilain.net> writes:

> On 3/1/12 10:21 AM, Nelson Benitez Leon wrote:
>> CuRL already reads it, but if $http_proxy has username but no password
>> curl will not ask you for the password.. so we read it ourselves to
>> detect that and ask for the password.
>
> That's not what this change does.  This change explicitly loads from
> the environment the 'http_proxy' variable and sets up curl to use it.
> As Junio said, this is (on its own) a regression.

Just to make sure there is no understanding down the road, I only
expressed a concern that this _might_ be a regression. That Mac OS X
behaviour is not something I observed first-hand.