From: Junio C Hamano Date: Mon, 24 Sep 2012 22:31:33 GMT Subject: Re: [PATCH v2 00/14] new git check-ignore sub-command Message-ID: <7v7grjxdbu.fsf@alter.siamese.dyndns.org> In-Reply-To: <1348170383-15751-1-git-send-email-git@adamspiers.org> Adam Spiers writes: > t/t0007-ignores.sh | 587 ++++++++++++++++++++++ I needed this to make it pass the test. I didn't see anything that is passed to expect_in via $text that would benefit from "echo -e" but I did not look too carefully; you may have had a reason to write "-e" there, and this patch may break for somebody else (namely, you), in which case please explain and justify the use of "-e" better. We need a solution that does not rely on the bash-ism. Thanks. -- >8 -- "echo -e" is a bash-ism that does not seem to be needed in the context of this test (both bash and dash passes the test without the extraneous "-e", but having "-e" breaks test run under dash). Signed-off-by: Junio C Hamano --- t/t0007-ignores.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t0007-ignores.sh b/t/t0007-ignores.sh index a0f571e..7fd7e53 100755 --- a/t/t0007-ignores.sh +++ b/t/t0007-ignores.sh @@ -19,7 +19,7 @@ expect_in () { then >"$dest" # avoid newline else - echo -e "$text" >"$dest" + echo "$text" >"$dest" fi } -- 1.7.12.1.451.gb433296