From: Junio C Hamano Date: Thu, 04 Oct 2012 19:09:47 GMT Subject: Re: [PATCH 6/6] log --grep: honor grep.patterntype etc. configuration variables Message-ID: <7v7gr6yryc.fsf@alter.siamese.dyndns.org> In-Reply-To: <20121004180122.GB2623@sigill.intra.peff.net> Jeff King writes: > On Thu, Oct 04, 2012 at 09:46:42AM -0700, Junio C Hamano wrote: > >> Jeff King writes: >> >> > Hmm. So I think this is a nice feature for some people, but I wonder if >> > we would run into any plumbing compatibility issues. People do tend to >> > use "log" as plumbing (since rev-list is not as capable). On the other >> > hand, I'd think most internal uses of "log --grep" would be passing >> > something along from the user, and the user would be happy to have it >> > interpreted by their chosen set of rules. >> >> This does make "rev-list --grep" aware of the configuration but at >> the same time --basic-regexp and friends are also available to it. > > Does it? Ah, it doesn't. You can still say "rev-list --perl-regexp --grep=pcre" but that is not what 6/6 does.