From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 24 Jun 2013 07:28:14 GMT
Subject: Re: [PATCH 4/6] t/t5528-push-default: generalize test_push_*
Message-ID: <7v7ghkdl2p.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CALKQrgeSbY3spjTp_m7kgt4TkFi8B5pNpLQ8wvDD+qkCYa+Mww@mail.gmail.com>

Johan Herland <johan@herland.net> writes:

>> +       git --git-dir="${3:-repo1}" log -1 --format='%h %s' "$2" >actual &&
>
> Isn't  ${3:-repo1} a bashism?

I do not think so.  But now I looked at it again, I think I would
use ${3-repo1} form in this case myself.  No caller passes an empty
string to the third place.