From: Junio C Hamano <junkio@cox.net>
Date: Tue, 31 Jan 2006 21:39:01 GMT
Subject: Re: [PATCH] Fix HTTP request result processing after slot reuse
Message-ID: <7v64o0ulfu.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060131190655.GE3873@reactrix.com>

Nick Hengeveld <nickh@reactrix.com> writes:

> Add a way to store the results of an HTTP request when a slot finishes
> so the results can be processed after the slot has been reused.
>
> Signed-off-by: Nick Hengeveld <nickh@reactrix.com>

I do not claim I understand this part of the code well, but it
feels awkward to see that a problem caused by a structure being
reused can be solved by having a pointer from that structure
that points at a static location.

These static variables are probably correct, provided if
fetch_index, fetch_indices and friends do not recurse into
themselves, but it just gives me this funny feeling...

Care to enlighten me, please?