From: Junio C Hamano Date: Fri, 03 Feb 2006 20:42:58 GMT Subject: Re: [PATCH 0/9] http-fetch fixes Message-ID: <7v64nwdvhp.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Mark Wooding writes: > Junio C Hamano wrote: > >> I briefly looked at the series; the following may be ready to be >> applied: >> >> [PATCH 2/9] http-fetch: Fix object list corruption in fill_activ... >> [PATCH 5/9] http-fetch: Fix message reporting rename of object file >> [PATCH 6/9] http: Turn on verbose Curl messages if GIT_CURL_VERB... >> [PATCH 7/9] http-fetch: Tidy control flow in process_alternate_r... >> >> For now however I'll wait and see for a while, in case you can >> reproduce the breakage Uwe found and add fixes to your set. > > I've not had any more trouble with this since, but I'm still worried > that the http fetcher is rather fragile. :-( > > What was wrong with 3/9, by the way? (It's the abort_active_slot patch > -- which does fix a real bug.) I saw Nick raised an alternative and you responded but I did not see Nick agreeing or disagreeing to it, and I haven't spent enough time on that to convince myself which way to go. That is why. Maybe this weekend.