From: Junio C Hamano Date: Fri, 07 Jul 2006 12:17:48 GMT Subject: Re: [PATCH] diff.c: respect diff.renames config option Message-ID: <7v64i9zk0j.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <7vpsghzmr1.fsf@assigned-by-dhcp.cox.net> Junio C Hamano writes: > I am more worried about somebody who opts-in finds breakage of > commands that happen to internally use low-level diff machinery > and expect the diff machinery does not automagically do funny > rename detection without being told. > ... > That is why I said I do not want this at _that_ low level. I do > not have objections to have the configuration at a layer closer > to the UI, e.g. things in builtin-log.c and builtin-diff.c. Upon closer look I think the revision pruning code is OK. So let's cook this as is in "next" and see what happens.