From: Junio C Hamano <junkio@cox.net>
Date: Fri, 07 Jul 2006 11:06:23 GMT
Subject: Re: [PATCH] Teach --text option to diff
Message-ID: <7v64i91xow.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <11522684373987-git-send-email-sf@b-i-t.de>

Stephan Feder <sf@b-i-t.de> writes:

> I have to send patches of binary data to a customer but the builtin diff
> was no help in this case.

Given the previous patch, and also your point #2 below, I would
have expected you to introduce an option to force files to be
treated as binary even when they are otherwise misidentified as
text, but this patch is going the other way.

Interesting.

> 1. The shorthand -a for --text is not implemented. Is there a conflicting
> shorthand?

I do not think of one offhand, but it's the responsibility for
the party to propose such an enhancement to do the study ;-)

> 2. For diffstat --text is ignored. It seems pointless because binary
> patch data is not for human consumption anyway.

> 3. No documentation yet. If the patch is accepted I will add a short
> description. To Documentation/diff-options.txt?

Most likely that would be the place.