From: Junio C Hamano <junkio@cox.net>
Date: Wed, 20 Sep 2006 17:17:18 GMT
Subject: Re: [PATCH] cvsimport move over to using git for each ref to read refs V3
Message-ID: <7v64fiihk1.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <451173B1.4060305@shadowen.org>

Andy Whitcroft <apw@shadowen.org> writes:

> Junio C Hamano wrote:
>> 
>> for-each-ref let's you limit the refs by leading path, so I do
>> not think "next if" inside the loop is needed if you say
>> 
>> 	for-each-ref --perl --format=$fmt refs/heads
>
> Stupid boy :)
>> 
>> Any reason you did not like my version that allows you to get
>> rid of the while() loop altogether?  (hint: replace eval in my
>> example with "print" and see what you are evaling)
>
> To my mind we avoid the 'mozilla repo' issue of 1000's of heads
> busting some string length limit, or requiring some _vast_ string to
> hold it (as perl is likely to cope).  Given we are sifting a small
> percentage of the data out of it.

Quite valid reasoning.

Will apply V3 with refs/heads filtering added; no need to
resend.