From: Junio C Hamano Date: Wed, 06 Dec 2006 19:01:03 GMT Subject: Re: [PATCH] git-svn: error out when the SVN connection fails during a fetch Message-ID: <7v64co4zo0.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <87psax3qmb.fsf@mid.deneb.enyo.de> Florian Weimer writes: > * Eric Wong: > >> Florian Weimer wrote: >>> * Eric Wong: >>> >>> > Does the following patch help? >>> >>> Don't think so. The issue is not timing-related. I've seen a failure >>> every 1000 requests, which suggests to me that it's hitting the >>> MaxKeepAliveRequests limit configured on the server. >> >> Actually, that's exactly what this patch should fix. git-svn restarts a >> child every 1000 revisions to avoid memory usage from going through the >> roof. > > Oh. My (limited) testing of the patch confirms that. Ok, so this means I should apply this one, right? -- >8 -- From: Eric Wong Date: Mon, 4 Dec 2006 00:51:16 -0800 Subject: [PATCH] git-svn: avoid network timeouts for long-running fetches Long-running fetches run inside children to avoid memory leaks. When we refork, the connection in the parent can be idle for a long time; attempting to reuse it in the next child can result in timeouts. Signed-off-by: Eric Wong --- git-svn.perl | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/git-svn.perl b/git-svn.perl index d0bd0bd..747daf0 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -459,6 +459,7 @@ sub fetch_lib { $min = $max + 1; $max += $inc; $max = $head if ($max > $head); + $SVN = libsvn_connect($SVN_URL); } restore_index($index); return { revision => $last_rev, commit => $last_commit }; -- 1.4.4.1.g6129