From: Junio C Hamano <junkio@cox.net>
Date: Thu, 11 Jan 2007 23:55:23 GMT
Subject: Re: What's cooking in git.git (topics)
Message-ID: <7v64bd15lg.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070111100800.GB28309@spearce.org>

"Shawn O. Pearce" <spearce@spearce.org> writes:

>> One minor problem that you inherited from the original algorithm
>> is the name priority.  If you have an annotated tag A and a
>> lightweight tag b, and ask "git describe --tags" in this graph:
>> 
>>     ---o---o---o---o---x
>>            A   b
>> 
>> you would still want to describe 'x' with A, not b.
>> Unfortunately you don't (and the original doesn't either).
>
> Actually I think you want to describe it with b.  If you ask
> '--tags' then you want the lightweight ones too.  In the case above
> the lightweight tag b better describes x as it has more in common
> with x than A has.

The reason why I would run the command with --tags is to cope
with this kind of graph.

             o---o---o---x
            /
    ---o---o---o---o---o---y
       b       A

in order to use lightweight ones as a back-up.  Otherwise we
would not have had the "prio" business there.

And I would prefer if the presense of lightweight 'c' tag did
not change how 'y' is described:


             o---o---o---x
            /
    ---o---o---o---o---o---y
       b       A       c