From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 11 Jun 2007 08:18:11 GMT
Subject: Re: [PATCH] Avoid double-slash in path names that depend on $(sharedir).
Message-ID: <7v645usy4c.fsf@assigned-by-dhcp.pobox.com>
In-Reply-To: <11815489372169-git-send-email-johannes.sixt@telecom.at>

Johannes Sixt <johannes.sixt@telecom.at> writes:

> diff --git a/Makefile b/Makefile
> index af84af9..c23031c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -144,7 +144,7 @@ STRIP ?= strip
>  prefix = $(HOME)
>  bindir = $(prefix)/bin
>  gitexecdir = $(bindir)
> -sharedir = $(prefix)/share/
> +sharedir = $(prefix)/share
>  template_dir = $(sharedir)/git-core/templates/
>  ifeq ($(prefix),/usr)
>  sysconfdir = /etc

This suggests that we would also want to drop the trailing slash
from template_dir, doesn't it?

I took a brief look at builtin-init-db.c but it seems that the
code is safe with or without the trailing slash there.