From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 05 Sep 2007 00:19:03 GMT
Subject: Re: [PATCH 2/3] archive: specfile support (--pretty=format: in archive files)
Message-ID: <7v642qm0aw.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <46DDE6B3.8010507@lsrfire.ath.cx>

René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:

> Here's that ugly code, by the way.  It adds two placeholders, %d for
> description and %D for description depth.  Shortcomings of this code:
> it adds three members to struct commit, it unconditionally computes
> the description when format_commit_message() -- even if the format
> string doesn't contain %d and %D, the patch is not nicely split up.
> But it convinced me that describe *can* indeed be librarified. :-)

Yeah, unconditional computation for %d/%D is really a killer.
Otherwise the change itself does not necessarily look too ugly,
though.