From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 28 Sep 2007 18:08:54 GMT
Subject: Re: [PATCH] alloc_ref(): allow for trailing NUL
Message-ID: <7v641upsqx.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <Pine.LNX.4.64.0709281711010.28395@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> On Fri, 28 Sep 2007, Daniel Barkalow wrote:
>
>> On Fri, 28 Sep 2007, Johannes Schindelin wrote:
>> 
>> > Further, I am quite sure that the same mistake will happen again, until we 
>> > change the function to get the name length, not the number of bytes to 
>> > allocate.
>> 
>> I agree. But leaving the majority of cases using the old convention is 
>> just confusing.
>
> Yeah, sorry, that patch was only half-cooked.
>
> If people agree with me, I'll redo the patch (fixing all calling sites, 
> too).

I think that is probably a better solution.