From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 26 Oct 2007 21:00:06 GMT
Subject: Re: [PATCH 5/9] Add tests for git hash-object
Message-ID: <7v640ty4kp.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1193307927-3592-6-git-send-email-aroben@apple.com>

Adam Roben <aroben@apple.com> writes:

> +test_expect_success \
> +    'hash a file' \
> +    "test $hello_sha1 = \$(git hash-object hello)"
> +
> +test_expect_success \
> +    'hash from stdin' \
> +    "test $hello_sha1 = \$(echo '$hello_content' | git hash-object --stdin)"

Needs to make sure no object has been written to the object
database at this point?

> +test_expect_success \
> +    'hash a file and write to database' \
> +    "test $hello_sha1 = \$(git hash-object -w hello)"

... and make sure the objectis written here?

> +test_expect_success \
> +    'hash from stdin and write to database' \
> +    "test $hello_sha1 = \$(echo '$hello_content' | git hash-object -w --stdin)"
> +
> +test_done

... and/or here?