From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 11 Nov 2007 22:52:26 GMT
Subject: Re: [PATCH] Move stripspace() and launch_editor() to strbuf.c
Message-ID: <7v6408bdjp.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <Pine.LNX.4.64.0711112227420.4362@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Maybe call_editor() instead of edit_buffer()?  Since we technically read 
> the file specified by "path" into the buffer "buffer", after having called 
> the editor.

Calling $EDITOR to edit the buffer is an implementation detail
of letting the user edit the buffer.  I think the function name
should express what it does more than how it does it.

My suggested name does not convey the "letting the user" part,
though.