From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 13 Mar 2008 20:48:35 GMT
Subject: Re: [PATCH 06/16] add test_cmp function for test scripts
Message-ID: <7v63vqxsd8.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080313120821.GA19485@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Wed, Mar 12, 2008 at 03:12:45PM -0700, Junio C Hamano wrote:
>
>> I think I have an earlier round of this in 'pu'.
>
> Oops, so you do. I remember discussing it but didn't recall a patch
> coming out of it.
>
> I see you have queued mine now in pu over yours. I actually think yours
> looks a little nicer (you sanity-check the comparator, and you are more
> careful with stdin (something that I considered, but figured we could
> add if something actually broke)).
>
> Any reason not to keep your existing one over mine?

Yours is much simpler.

And it is tested on the field, so if it ever breaks I have somebody else
to blame ;-)