From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 09 Apr 2008 06:50:35 GMT
Subject: Re: [PATCH 6/8] lib-git-svn.sh: Fix quoting issues with paths containing shell metacharacters
Message-ID: <7v63urcyis.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1207704604-30393-6-git-send-email-bdonlan@fushizen.net>

Bryan Donlan <bdonlan@fushizen.net> writes:

> Signed-off-by: Bryan Donlan <bdonlan@fushizen.net>
> ---
>  t/lib-git-svn.sh |   11 ++++++-----
>  1 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/t/lib-git-svn.sh b/t/lib-git-svn.sh
> index 9decd2e..1b37ba8 100644
> --- a/t/lib-git-svn.sh
> +++ b/t/lib-git-svn.sh
> @@ -7,9 +7,9 @@ then
>  	exit
>  fi
>  
> -GIT_DIR=$PWD/.git
> -GIT_SVN_DIR=$GIT_DIR/svn/git-svn
> -SVN_TREE=$GIT_SVN_DIR/svn-tree
> +GIT_DIR="$PWD/.git"
> +GIT_SVN_DIR="$GIT_DIR/svn/git-svn"
> +SVN_TREE="$GIT_SVN_DIR/svn-tree"

Same comment as the one for [1/8].

>  
>  svn >/dev/null 2>&1
>  if test $? -ne 1
> @@ -19,13 +19,14 @@ then
>      exit
>  fi
>  
> -svnrepo=$PWD/svnrepo
> +svnrepo="$PWD/svnrepo"
> +export svnrepo

Likewise, except "export" is a good way to propagate it down.

>  perl -w -e "
>  use SVN::Core;
>  use SVN::Repos;
>  \$SVN::Core::VERSION gt '1.1.0' or exit(42);
> -system(qw/svnadmin create --fs-type fsfs/, '$svnrepo') == 0 or exit(41);
> +system(qw/svnadmin create --fs-type fsfs/, \$ENV{svnrepo}) == 0 or exit(41);
>  " >&3 2>&4
>  x=$?
>  if test $x -ne 0