From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 05 Nov 2008 22:23:08 GMT
Subject: Re: [PATCH] push: fix local refs update if already up-to-date
Message-ID: <7v63n1lsmr.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20081105215706.GA32063@localhost>

Clemens Buchacher <drizzd@aon.at> writes:

> On Wed, Nov 05, 2008 at 09:28:49PM +0100, Clemens Buchacher wrote:
>> On Tue, Nov 04, 2008 at 09:49:32PM -0500, Jeff King wrote:
>> [...]
>> > However, I would like to make one additional request.  Since you are
>> > killing off all usage of new_sha1 initial assignment, I think it makes
>> > sense to just get rid of the variable entirely, so it cannot create
>> > confusion later.
>
> Considering that the ref is initialized to the null_sha1, do you think it
> would be Ok to do the following instead?

Yeah, that's pretty much what I munged and committed.