From: Junio C Hamano Date: Sun, 11 Jan 2009 22:25:34 GMT Subject: Re: [PATCH] Cleanup of unused symcache variable inside diff-lib.c Message-ID: <7v63klpjj5.fsf@gitster.siamese.dyndns.org> In-Reply-To: <86ab9x8t4a.fsf@broadpark.no> Kjetil Barvik writes: > And the 'a' and the 'd' in the DCO I do agree with in this particular > situation, so I added a '--signoff' to the patches. I think Dscho's suggestion was to sign-off when you commit, not when you format-patch. It won't make any difference either way to me nor other people who reads the list, because nobody can tell which way you used by looking at your e-mail, but it is a good habit to get into if you work on git or the kernel.