From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 25 Mar 2009 02:24:42 GMT
Subject: Re: [BUG?] How to make a shared/restricted repo?
Message-ID: <7v63hybaqd.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <200903250311.56300.johan@herland.net>

Johan Herland <johan@herland.net> writes:

> On Wednesday 25 March 2009, Junio C Hamano wrote:
>> You might like to try a patch like this (untested).
>>
>>  path.c |   17 +++++------------
>>  1 files changed, 5 insertions(+), 12 deletions(-)
>
> Thanks!
>
> This works much better :)
>
> However, there are still some questions/issues:
>
> - t1301-shared-repo.sh fails:
>     Oops, .git/HEAD is not 0664 but -rw-rw---- [...]
>     * FAIL 3: shared=1 does not clear bits preset by umask 022
>   (I guess this is expected, as your patch changes the assumptions)

I'd rather say the patch breaks people's expectations.