From: Junio C Hamano Date: Thu, 07 May 2009 20:43:06 GMT Subject: Re: Message-ID: <7v63gcejad.fsf@alter.siamese.dyndns.org> In-Reply-To: Linus Torvalds writes: > On Thu, 7 May 2009, Linus Torvalds wrote: >> >> The patch is TOTALLY UNTESTED. It also worries me that 'git checkout' >> seems to do _two_ 'lstat()' calls per file. I didn't look any more >> closely, but there may be other issues here. > > Hmm. The second pass comes from > > show_local_changes(&new->commit->object); > > (this is the "git checkout" without actual filenames), and is suppressed > if we ask for a quiet checkout. But it's sad how it re-loads the index. I > wonder where the CE_VALID bit got dropped. I do not think you mean CE_VALID; CE_UPTODATE isn't it?