From: Junio C Hamano Date: Wed, 10 Jun 2009 07:15:54 GMT Subject: [RF sanity check] send-email threading fixes (was Re: [PATCH 3/6] send-email: fix threaded mails without chain-reply-to) Message-ID: <7v63f4v9sl.fsf@alter.siamese.dyndns.org> In-Reply-To: <7vhbyo1vr7.fsf@alter.siamese.dyndns.org> Junio C Hamano writes: > You were too polite to say "by a hidden code style change", instead of > saying something stronger,... Erm, I meant "you were very polite and said"... In any case, here is what I came up with by reshuffling your six patches. [PATCH 1/6] add a test for git-send-email for non-threaded mails [PATCH 2/6] send-email: fix non-threaded mails [PATCH 3/6] doc/send-email: clarify the behavior of --in-reply-to with --no-thread [PATCH 4/6] send-email: fix threaded mails without chain-reply-to [PATCH 5/6] add a test for git-send-email for threaded mails without chain-reply-to [PATCH 6/6] send-email: fix a typo in a comment The first three patches apply to the tip of 'maint', which is currently at 802f9c9 (diff.c: plug a memory leak in an error path, 2009-06-08). The first one exposes breakage introduced by 3e0c4ff and then the second one fixes it. Patch 4/6 applies on top of 15da108 to fix a breakage introduced by that commit. Together with the result of applying the first three patches to maint, they fix --no-thread and --thread (without --chain-reply-to) cases. The result can be verified by applying Patch 5/6 on top of them. They will appear in tonight's 'pu'; the overall tip for the topic would be at 479ad6b (unless I find breakages during the final testing). Thanks.