From: Junio C Hamano Date: Sun, 15 Nov 2009 09:08:09 GMT Subject: Re: [PATCH] http-backend: Fix bad treatment of uintmax_t in Content-Length Message-ID: <7v639crw92.fsf@alter.siamese.dyndns.org> In-Reply-To: <905315640911141349t7121baa8vc0b2be59fa348512@mail.gmail.com> Tarmigan writes: > On Wed, Nov 11, 2009 at 8:42 PM, Shawn O. Pearce wrote: >> Our Content-Length needs to report an off_t, which could be larger >> precision than size_t on this system (e.g. 32 bit binary built with >> 64 bit large file support). >> >> We also shouldn't be passing a size_t parameter to printf when >> we've used PRIuMAX as the format specifier. >> >> Fix both issues by using uintmax_t for the hdr_int() routine, >> allowing strbuf's size_t to automatically upcast, and off_t to >> always fit. >> >> Also fixed the copy loop we use inside of send_local_file(), we never >> actually updated the size variable so we might as well not use it. >> >> Reported-by: Tarmigan > > Tested-by: Tarmigan Thanks; care to spell your name in full (as if you are publishing say a scientific paper)? I am guessing that the other Tarmigan with full name who posted a few patches is the same person as you.