From: Junio C Hamano Date: Sun, 22 Nov 2009 17:54:10 GMT Subject: Re: [PATCH] send-email: new 'add-envelope' option Message-ID: <7v6392h2d9.fsf@alter.siamese.dyndns.org> In-Reply-To: <94a0d4530911220403w7238dab7saf18830a89f2add5@mail.gmail.com> Felipe Contreras writes: > Maybe I should wait until somebody adds the tests to --envelope-sender > before pushing this patch. You can say that if you want to be difficult to work with, or you can be that somebody yourself and make a difference. Let me show you that we can be constructive for a change ;-) How about something trivial like this? -- >8 -- Subject: [PATCH] t9001: test --envelope-sender option of send-email Signed-off-by: Junio C Hamano --- t/t9001-send-email.sh | 17 +++++++++++++++++ 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh index 84a7f03..004e81c 100755 --- a/t/t9001-send-email.sh +++ b/t/t9001-send-email.sh @@ -95,6 +95,23 @@ test_expect_success \ 'Verify commandline' \ 'test_cmp expected commandline1' +test_expect_success 'Send patches with --envelope-sender' ' + clean_fake_sendmail && + git send-email --envelope-sender="Patch Contributer " --suppress-cc=sob --from="Example " --to=nobody@example.com --smtp-server="$(pwd)/fake.sendmail" $patches 2>errors +' + +cat >expected <<\EOF +!patch@example.com! +!-i! +!nobody@example.com! +!author@example.com! +!one@example.com! +!two@example.com! +EOF +test_expect_success \ + 'Verify commandline' \ + 'test_cmp expected commandline1' + cat >expected-show-all-headers <<\EOF 0001-Second.patch (mbox) Adding cc: A from line 'From: A '