From: Junio C Hamano Date: Tue, 12 Jan 2010 08:29:58 GMT Subject: Re: [PATCH] grep: do not do external grep on skip-worktree entries Message-ID: <7v63774tfd.fsf@alter.siamese.dyndns.org> In-Reply-To: Linus Torvalds writes: > Ack. Works for me. And with that, I'd love for it to go in, and get rid of > the external grep. Performance is now a non-issue (it goes both ways), and > the internal grep doesn't have the bug with separators between multi-line > greps. > > And dropping the external one gets rid of all the issues with PATHs, crap > 'grep' implementations, and removes actual code. Goodie. > > Linus Before going forward, I found two small nits that should go to maint.