From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 06 Jul 2010 02:36:27 GMT
Subject: Re: [PATCH 2/2] Makefile: work around ksh's failure to handle missing list argument to for loop
Message-ID: <7v630t72vo.fsf@alter.siamese.dyndns.org>
In-Reply-To: <AANLkTin0h8DUWo3sfhRdA7NCCCPLKXfQzSDvWX7p1OPq@mail.gmail.com>

Brandon Casey <drafnel@gmail.com> writes:

> $(foreach) works too.  I only avoided it because it has already caused a
> problem once before by creating a command line that exceeded the
> maximum argument list length on IRIX.

Ok, fair enough.

> REMOTE_CURL_ALIASES only has 3 items in it right now, and probably
> won't grow much larger, if it grows at all, so there is little chance of
> exceeding the maximum argument list length on IRIX.  So $(foreach) is
> fine with me if you think that reads better.

Well your patch fixes the issue, and I would actually prefer it as long as
it is explained well ;-).

Thanks.