From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 08 Mar 2011 20:09:12 GMT
Subject: Re: [PATCH jk/strbuf-vaddf] compat: fall back on __va_copy if available
Message-ID: <7v62rte5nb.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110308083344.GD26516@elie>

Jonathan Nieder <jrnieder@gmail.com> writes:

> Discovered by building with CC="gcc -std=c89" on an amd64 machine:
>
>  $ make CC=c89 strbuf.o
>  [...]

>  strbuf.c: In function ‘strbuf_vaddf’:

This is a tangent but when you quote from compiler output could you be in
C locale so that it would be easier for everybody to get the same result?
It will have the added benefit that we won't have to deal with these fancy
matching quotes I personally hate to see in commit log messages.

Thanks, the patch looks good.