From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 30 Mar 2011 22:22:35 GMT
Subject: Re: [PATCH 2/3] remote: separate the concept of push and fetch mirrors
Message-ID: <7v62r0meok.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110330205734.GA2940@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I think the problem is not that users lack common sense. It is that we
> give them an option called "--mirror" that sets up a bogus config in
> some circumstances. So it is the git developers who lack common sense, I
> think. :)
>
> Specifically, 84bb2df should not have started setting "remote.*.mirror",
> as it was already about fetching into a bare repository. And probably
> --mirror in a non-bare repo should have complained from the beginning.

What I meant was that what 84bb2df did was sufficient for people who know
which one they wanted and stuck with what they said they wanted.

What would we call a person who first asks "I want a push mirror to save
away my work" and then says "now let's fetch from there", without
realizing that such a fetch will obliterate his work?  I agree that it
probably is asking a bit more than "common sense"; it perhaps requires an
ability to think for 5 minutes what oneself is doing ;-).

> But hey, hindsight is 20/20.

Indeed.

Thanks.