From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 16 May 2011 14:39:20 GMT
Subject: Re: [PATCH 08/11] streaming_write_entry(): support files with holes
Message-ID: <7v62pan207.fsf@alter.siamese.dyndns.org>
In-Reply-To: <BANLkTi=VKb44yYuXdKLxrvFCVkfsDZSb4Q@mail.gmail.com>

Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:

> On Mon, May 16, 2011 at 7:30 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> One typical use of a large binary file is to hold a sparse on-disk hash
>> table with a lot of holes. Help preserving the holes with lseek().
>
> Should that be done only with big enough holes? Random zeros may
> increase the number of syscalls unnecessarily.

I think that is a valid concern, but doesn't the code do that already?