From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 13 Sep 2011 17:13:56 GMT
Subject: Re: [PATCH] t3200: clean up checks for file existence
Message-ID: <7v62kwxt4b.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110913161358.GB28634@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Here it is, on top of mg/branch-list. The "test without -f" bits could
> actually be squashed in to your commits if we really want clean history,
> but I don't think it's a big deal.

Thanks.

In the longer term, we might want to update these tests further so that
they do not fail when implementation is updated not to write loose refs,
e.g.

>  test_expect_success \
>      'git branch abc should create a branch' \
> -    'git branch abc && test -f .git/refs/heads/abc'
> +    'git branch abc && test_path_is_file .git/refs/heads/abc'

    git branch abc && git show-ref -q --verify refs/heads/abc

But this patch is about correctness first, so I'll queue it as-is.