From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 16 Sep 2011 20:24:11 GMT
Subject: Re: [PATCH] gitweb: Strip non-printable characters from syntax highlighter output
Message-ID: <7v62ksfd78.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201109162058.51132.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

> So actually now I see that while this line is good to have in esc_html(),
> it is not really necessary in sanitize().
>
> But anyway we don't want to replace undef with an empty string; undef is
> (usually) an error, and we want to catch it, not to hide it.

Heh, get off your high horse---whoever wrote such a caller that calls the
subroutine and uses its result without checking it against undef is not
qualified to make such a statement. I do not think letting "perl -w"
notice and complain about an attempt to concatenate undef with string
counts as "catching" it.