From: Junio C Hamano Date: Sat, 12 Nov 2011 06:50:28 GMT Subject: Re: RFH: unexpected reflog behavior with --since= Message-ID: <7v62iprg0b.fsf@alter.siamese.dyndns.org> In-Reply-To: <20111109222032.GB31535@sigill.intra.peff.net> Jeff King writes: > So I think the only decision is whether "--since" should respect the > commit timestamps (and be used as a sort of "grep" filter for > timestamps), or whether it should be respecting the fake history we > create when doing a reflog walk. > > I think I am leaning towards the latter. I tend to agree as far as the semantics go. Also at least as a short term solution at the implementation level, I am OK with the change. But in the longer term, I have this suspicion that we should not be rewriting commit objects themselves with these phony data, which makes things like "git log -g --stat" and "git log --parents -g" totally useless. That of course is not a fault of this patch; it does not make things any worse than the original, and that is why I say I am OK with it. Thanks.