From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 10 Feb 2012 21:17:11 GMT
Subject: Re: [PATCH v2 28/51] refs.c: rename ref_array -> ref_dir
Message-ID: <7v62fepew8.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120210204457.GD5504@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

>> If everything_local() is trying to check that the references are in the
>> local repository plus alternates, then it is incorrect that
>> everything_local() doesn't consider alternate references in its
>> determination.  My guess is that this is the case, and that something
>> like the following might be the fix:
>
> Junio could answer more authoritatively than I, but I am pretty sure it
> is the latter. The point is to skip the expensive find_common
> negotiation if we know that there are no objects to fetch. Thus the
> "local" here is "do we have them on this side of the git-protocol
> connection", not "do we have them in our non-alternates repository".

Correct.  The function is about "do we need to get any object from the
other side?" optimization.

I originally thought to go through the rest of your message, but I
realized I can just say "everything you said is correct and I have nothing
more to add."

Thanks.