From: Junio C Hamano Date: Tue, 06 Mar 2012 18:58:22 GMT Subject: Re: [PATCH 1/2] Fix a warning about conversion to float Message-ID: <7v62ehtv3l.fsf@alter.siamese.dyndns.org> In-Reply-To: <1331024077-5736-1-git-send-email-user@vincent-VirtualBox> Vincent van Ravesteijn writes: > From: Vincent van Ravesteijn > > Below in the same function, val is correctly casted to a float. Do this also > for the initialization of x. Hrm, is it correctly casted or needlessly casted? It is unclear what problem you are trying to solve here. > @@ -550,6 +550,7 @@ static int sqrti(int val) > return (int)x; > } > > + > static struct commit_list *skip_away(struct commit_list *list, int count) Huh?