From: Junio C Hamano Date: Tue, 15 May 2012 17:01:42 GMT Subject: Re: [PATCH v5] completion: add new __git_complete helper Message-ID: <7v62bxfkeh.fsf@alter.siamese.dyndns.org> In-Reply-To: Felipe Contreras writes: > On Mon, May 14, 2012 at 9:09 PM, Junio C Hamano wrote: >> Felipe Contreras writes: >> >>>> Here is my attempt to explain why none of them needs to be quoted: >>>> ... >>> I don't understand that. >> >> That was my attempt to give the readers some context to understand what >> comes after that.... > > I mean I don't understand this "Note that none of the variable > reference in the implementation of this function needs dq around it." You later say "then yeah, I agree.", so I am interpreting this "I don't understand" to mean that you do agree that missing dq around $1, $2 and $wrapper in the function is _not_ a problem, and you do not understand why it needs to be explained. See below. > I suppose you meant 'references' (as that would make it grammatically > correct AFAICS),... Correct. > but I still don't understand what you are trying so > say. That the way the arguments are used in the __git_complete > function makes it so double quotes are irrelevant? Correct. > If so, then yeah, I agree. > > Is there something actionable? Like adding an explanation, preferrably a better one, there, so that the next person do not have to wonder and waste time like I did?